From: Donald Sharp <sharpd@cumulusnetworks.com>
Date: Fri, 7 Jun 2019 13:27:38 +0000 (-0400)
Subject: lib: On some platforms function did not return anything
X-Git-Tag: base_7.2~248^2~1
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=adc109b5a26897568f616aa565b9b18019722993;p=matthieu%2Ffrr.git

lib: On some platforms function did not return anything

On some compiler platforms the md5 setup function was
not returning anything.  Place failure case on the bottom
to properly handle this situation.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
---

diff --git a/lib/sockopt.c b/lib/sockopt.c
index 89f3d5b594..8e38a29278 100644
--- a/lib/sockopt.c
+++ b/lib/sockopt.c
@@ -701,6 +701,12 @@ int sockopt_tcp_signature_ext(int sock, union sockunion *su, uint16_t prefixlen,
 	}
 	return ret;
 #endif /* HAVE_TCP_MD5SIG */
+
+	/*
+	 * Making compiler happy.  If we get to this point we probably
+	 * have done something really really wrong.
+	 */
+	return -2;
 }
 
 int sockopt_tcp_signature(int sock, union sockunion *su, const char *password)