From: Donald Sharp <sharpd@cumulusnetworks.com>
Date: Fri, 16 Mar 2018 22:38:25 +0000 (-0400)
Subject: zebra: Allow duplicate entry of a route
X-Git-Tag: frr-5.0-dev~146^2~1
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=ad97d1c10af12cbfb45d0f5f3a6002738115fe12;p=matthieu%2Ffrr.git

zebra: Allow duplicate entry of a route

If a user enters a route inside a non kernel existant vrf:

vrf BLOOP
  ip route 4.3.2.0/24 192.168.201.1
!

They should be able to enter it over and over and over and
over and over no matter how futile it is.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
---

diff --git a/zebra/zebra_vty.c b/zebra/zebra_vty.c
index ea4d1a9feb..d0e2529924 100644
--- a/zebra/zebra_vty.c
+++ b/zebra/zebra_vty.c
@@ -249,7 +249,11 @@ static int zebra_static_route_holdem(struct zebra_vrf *zvrf,
 			return CMD_SUCCESS;
 		}
 
-		assert(!"We should not have found a duplicate and not remove it");
+		/*
+		 * If a person enters the same line again
+		 * we need to silently accept it
+		 */
+		return CMD_SUCCESS;
 	}
 
 	listnode_add_sort(static_list, shr);