From: Denil Vira <denil@cumulusnetworks.com>
Date: Thu, 23 Jul 2015 13:52:18 +0000 (-0700)
Subject: bgpd: Fix useless call in bgpd/bgp_mplsvpn.c
X-Git-Tag: frr-2.0-rc1~631
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=a3da12a80c21edf9db000c6458c351148adae8ae;p=matthieu%2Ffrr.git

bgpd: Fix useless call in bgpd/bgp_mplsvpn.c

Coverity scan ID : 1302528. Calling "decode_label(pnt)" is only useful for its return value, which is
ignored. Removed the call.

Signed-off-by: Denil Vira <denil@cumulusnetworks.com>
(cherry picked from commit 7053d8176ce502aabe39bf167f01354654bde5df)
---

diff --git a/bgpd/bgp_mplsvpn.c b/bgpd/bgp_mplsvpn.c
index 2510e2e040..d7ac8923e6 100644
--- a/bgpd/bgp_mplsvpn.c
+++ b/bgpd/bgp_mplsvpn.c
@@ -136,9 +136,6 @@ bgp_nlri_parse_vpnv4 (struct peer *peer, struct attr *attr,
 	  return -1;
 	}
 
-      /* XXX: Not doing anything with the label */
-      decode_label (pnt);
-
       /* Fetch prefix length. */
       prefixlen = *pnt++;
       p.family = afi2family (packet->afi);