From: Donald Sharp <sharpd@cumulusnetworks.com>
Date: Sat, 7 Oct 2017 12:53:35 +0000 (-0400)
Subject: isisd: Fix leaked memory in error case
X-Git-Tag: frr-4.0-dev~219^2~7
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=a3acf37dc262f7f91fbda00d242af64e89b425c8;p=matthieu%2Ffrr.git

isisd: Fix leaked memory in error case

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
---

diff --git a/isisd/isis_pdu.c b/isisd/isis_pdu.c
index be989cbabb..9c68fe5966 100644
--- a/isisd/isis_pdu.c
+++ b/isisd/isis_pdu.c
@@ -1546,8 +1546,11 @@ int send_hello(struct isis_circuit *circuit, int level)
 
 	isis_tlvs_add_auth(tlvs, &circuit->passwd);
 
-	if (!listcount(circuit->area->area_addrs))
+	if (!listcount(circuit->area->area_addrs)) {
+		isis_free_tlvs(tlvs);
 		return ISIS_WARNING;
+	}
+
 	isis_tlvs_add_area_addresses(tlvs, circuit->area->area_addrs);
 
 	if (circuit->circ_type == CIRCUIT_T_BROADCAST)