From: Donald Sharp <sharpd@cumulusnetworks.com>
Date: Wed, 13 Dec 2017 15:58:55 +0000 (-0500)
Subject: ospf6d: Don't assign to values that are never read
X-Git-Tag: frr-4.0-dev~90^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=a35bb96dee99fbadb4f03395ad34d657b3d5e110;p=mirror%2Ffrr.git

ospf6d: Don't assign to values that are never read

offset and offsetlen are never used without reassigning
in the code.  So comment out the assignments and
in case we want to start using the code for snmp
changes in the future.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
---

diff --git a/ospf6d/ospf6_snmp.c b/ospf6d/ospf6_snmp.c
index c148107449..a448645960 100644
--- a/ospf6d/ospf6_snmp.c
+++ b/ospf6d/ospf6_snmp.c
@@ -914,7 +914,7 @@ static u_char *ospfv3WwLsdbEntry(struct variable *v, oid *name, size_t *length,
 	if (len)
 		id = htonl(*offset);
 	offset += len;
-	offsetlen -= len;
+	//offsetlen -= len;  // Add back in if we need it again
 
 	if (exact) {
 		if (v->magic & OSPFv3WWASTABLE) {
@@ -1080,8 +1080,8 @@ static u_char *ospfv3IfEntry(struct variable *v, oid *name, size_t *length,
 	len = (offsetlen < 1 ? 0 : 1);
 	if (len)
 		instid = *offset;
-	offset += len;
-	offsetlen -= len;
+	//offset += len; // Add back in if we ever start using again
+	//offsetlen -= len;
 
 	if (exact) {
 		oi = ospf6_interface_lookup_by_ifindex(ifindex);
@@ -1241,8 +1241,8 @@ static u_char *ospfv3NbrEntry(struct variable *v, oid *name, size_t *length,
 	len = (offsetlen < 1 ? 0 : 1);
 	if (len)
 		rtrid = htonl(*offset);
-	offset += len;
-	offsetlen -= len;
+	//offset += len; // Add back in if we ever start looking at data
+	//offsetlen -= len;
 
 	if (exact) {
 		oi = ospf6_interface_lookup_by_ifindex(ifindex);