From: Quentin Young <qlyoung@cumulusnetworks.com>
Date: Fri, 20 Mar 2020 21:31:35 +0000 (-0400)
Subject: ospfd: fix memleak from fuzzing modifications
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=a12e7550c5acf4293ef9c2bb24f613e7b4aacd29;p=matthieu%2Ffrr.git

ospfd: fix memleak from fuzzing modifications

skipping a flood results in refcnt not being decremented and in the long
run a memleak, unfortunately we gotta do this one

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
---

diff --git a/ospfd/ospf_packet.c b/ospfd/ospf_packet.c
index 707aae438c..c99f03f665 100644
--- a/ospfd/ospf_packet.c
+++ b/ospfd/ospf_packet.c
@@ -2130,12 +2130,10 @@ static void ospf_ls_upd(struct ospf *ospf, struct ip *iph,
 				DISCARD_LSA(lsa, 4);
 			}
 
-#ifndef FUZZING
 			/* Actual flooding procedure. */
 			if (ospf_flood(oi->ospf, nbr, current, lsa)
 			    < 0) /* Trap NSSA later. */
 				DISCARD_LSA(lsa, 5);
-#endif
 			continue;
 		}