From: Igor Ryzhov <iryzhov@nfware.com>
Date: Sat, 21 Oct 2023 09:56:49 +0000 (+0300)
Subject: lib: remove incorrect comment from northbound
X-Git-Tag: base_10.0~345^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=a041d3169b642696d12cee1b33c05600c01b202a;p=mirror%2Ffrr.git

lib: remove incorrect comment from northbound

This was true when we had only a CLI for configuration. Now mgmtd has a
public frontend interface that can be used by external applications, and
they can send invalid requests that lead to errors.

This is still true for CLI though, so the same comment still stays in
`nb_cli_apply_changes_internal`.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
---

diff --git a/lib/northbound.c b/lib/northbound.c
index 69b96d3656..be49d92841 100644
--- a/lib/northbound.c
+++ b/lib/northbound.c
@@ -906,11 +906,6 @@ void nb_candidate_edit_config_changes(
 	if (error && *error) {
 		char buf[BUFSIZ];
 
-		/*
-		 * Failure to edit the candidate configuration should never
-		 * happen in practice, unless there's a bug in the code. When
-		 * that happens, log the error but otherwise ignore it.
-		 */
 		snprintf(err_buf, err_bufsize,
 			 "%% Failed to edit configuration.\n\n%s",
 			 yang_print_errors(ly_native_ctx, buf, sizeof(buf)));