From: Martin Winter <mwinter@opensourcerouting.org>
Date: Thu, 10 Apr 2025 13:58:44 +0000 (+0200)
Subject: tools: Add pathspace option to generate_support_bundle
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=9acadf8d3f41385df287d7eb564c57f5fbec9350;p=mirror%2Ffrr.git

tools: Add pathspace option to generate_support_bundle

Adding a `-N` pathspace option to the generate_support_bundle.py
to support FRR running in a non-default namespace with a prefix
on the config/socket options.
The same pathspace will be prepended to the output log files (if
specified)

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
---

diff --git a/tools/generate_support_bundle.py b/tools/generate_support_bundle.py
index 04a374d850..a646e7eea1 100755
--- a/tools/generate_support_bundle.py
+++ b/tools/generate_support_bundle.py
@@ -32,6 +32,9 @@ def main():
     parser.add_argument(
         "-l", "--log-dir", default="/var/log/frr", help="directory for logfiles"
     )
+    parser.add_argument(
+        "-N", "--pathspace", help="Insert prefix into config & socket paths"
+    )
     args = parser.parse_args()
 
     collecting = False  # file format has sentinels (seem superfluous)
@@ -69,13 +72,22 @@ def main():
     # Spawn a vtysh to fetch each set of commands
     procs = []
     for proc in proc_cmds:
-        ofn = os.path.join(args.log_dir, proc + "_support_bundle.log")
-        p = subprocess.Popen(
-            ["/usr/bin/env", "vtysh", "-t"],
-            stdin=proc_cmds[proc],
-            stdout=open_with_backup(ofn),
-            stderr=subprocess.STDOUT,
-        )
+        if args.pathspace:
+            ofn = os.path.join(args.log_dir, args.pathspace + "_" + proc + "_support_bundle.log")
+            p = subprocess.Popen(
+                ["/usr/bin/env", "vtysh", "-t", "-N", args.pathspace],
+                stdin=proc_cmds[proc],
+                stdout=open_with_backup(ofn),
+                stderr=subprocess.STDOUT,
+            )
+        else:
+            ofn = os.path.join(args.log_dir, proc + "_support_bundle.log")
+            p = subprocess.Popen(
+                ["/usr/bin/env", "vtysh", "-t"],
+                stdin=proc_cmds[proc],
+                stdout=open_with_backup(ofn),
+                stderr=subprocess.STDOUT,
+            )
         procs.append(p)
 
     for p in procs: