From: Renato Westphal <renato@opensourcerouting.org>
Date: Fri, 4 Jan 2019 21:08:10 +0000 (-0200)
Subject: ripd: failure to create a socket shouldn't be a fatal error
X-Git-Tag: 7.1_pulled~99^2~11
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=9852be711c80430004ed9ee0bd718476837896e8;p=matthieu%2Ffrr.git

ripd: failure to create a socket shouldn't be a fatal error

The ripd code can handle this error just fine (e.g. reject the
configuration transaction), there's no need to exit when a socket
fails to be created.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
---

diff --git a/ripd/ripd.c b/ripd/ripd.c
index 916fba2269..c6abfb557d 100644
--- a/ripd/ripd.c
+++ b/ripd/ripd.c
@@ -1347,7 +1347,7 @@ int rip_create_socket(void)
 	if (sock < 0) {
 		flog_err_sys(EC_LIB_SOCKET, "Cannot create UDP socket: %s",
 			     safe_strerror(errno));
-		exit(1);
+		return -1;
 	}
 
 	sockopt_broadcast(sock);