From: Donald Sharp <sharpd@cumulusnetworks.com>
Date: Tue, 7 Jun 2016 15:00:53 +0000 (-0400)
Subject: pimd: Make pim_pkt_dump use standard lib functions
X-Git-Tag: frr-2.0-rc1~588
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=95ff066772b10e534ea235482d1f93c97bc49d85;p=matthieu%2Ffrr.git

pimd: Make pim_pkt_dump use standard lib functions

pim_pkt_dump was creating a custom function to dump
detailed packet data.  Switch it over to use
zlog_hexdump.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
---

diff --git a/pimd/pim_util.c b/pimd/pim_util.c
index fdfed2bf23..57a8488eca 100644
--- a/pimd/pim_util.c
+++ b/pimd/pim_util.c
@@ -100,23 +100,8 @@ uint16_t igmp_msg_decode8to16(uint8_t code)
 
 void pim_pkt_dump(const char *label, const uint8_t *buf, int size)
 {
-  char dump_buf[1000];
-  int i = 0;
-  int j = 0;
-
-  for (; i < size; ++i, j += 2) {
-    int left = sizeof(dump_buf) - j;
-    if (left < 4) {
-      if (left > 1) {
-	strcat(dump_buf + j, "!"); /* mark as truncated */
-      }
-      break;
-    }
-    snprintf(dump_buf + j, left, "%02x", buf[i]);
-  }
-
-  zlog_debug("%s: pkt dump size=%d: %s",
+  zlog_debug("%s: pkt dump size=%d",
 	     label,
-	     size,
-	     dump_buf);
+	     size);
+  zlog_hexdump(buf, size);
 }