From: Paul Jakma <paul.jakma@sun.com>
Date: Fri, 12 May 2006 23:17:38 +0000 (+0000)
Subject: [lib] CID #3, fix forward-null errors in vty_prefix_list_uninstall
X-Git-Tag: frr-2.0-rc1~2705
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=9376c3421ae9ccc37e51ed742c5d0bed333f8d20;p=mirror%2Ffrr.git

[lib] CID #3, fix forward-null errors in vty_prefix_list_uninstall

2006-05-12 Paul Jakma <paul.jakma@sun.com>

	* plist.c: (vty_prefix_list_uninstall) Fix potential NULL deref
	  of prefix and typestr strings, Coverity CID #3.
---

diff --git a/lib/ChangeLog b/lib/ChangeLog
index 9e6dc85220..64fa8518ad 100644
--- a/lib/ChangeLog
+++ b/lib/ChangeLog
@@ -1,3 +1,8 @@
+2006-05-12 Paul Jakma <paul.jakma@sun.com>
+
+	* plist.c: (vty_prefix_list_uninstall) Fix potential NULL deref
+	  of prefix and typestr strings, Coverity CID #3.
+
 2006-03-30 Paul Jakma <paul.jakma@sun.com>
 
 	* command.h: (DEFUN_CMD_FUNC_TEXT) Annotate arguments as
diff --git a/lib/plist.c b/lib/plist.c
index 83c5aa0c71..6caece0e36 100644
--- a/lib/plist.c
+++ b/lib/plist.c
@@ -804,6 +804,13 @@ vty_prefix_list_uninstall (struct vty *vty, afi_t afi, const char *name,
       return CMD_SUCCESS;
     }
 
+  /* We must have, at a minimum, both the type and prefix here */
+  if ((typestr == NULL) || (prefix == NULL))
+    {
+      vty_out (vty, "%% Both prefix and type required%s", VTY_NEWLINE);
+      return CMD_WARNING;
+    }
+
   /* Check sequence number. */
   if (seq)
     seqnum = atoi (seq);