From: Donald Sharp <sharpd@cumulusnetworks.com>
Date: Thu, 2 Feb 2017 00:51:31 +0000 (-0500)
Subject: lib: Fix possible array overrun
X-Git-Tag: frr-3.0-branchpoint~51^2~6
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=9010012aa140c0301d1ae1121a0f4d16b22dcb0b;p=matthieu%2Ffrr.git

lib: Fix possible array overrun

It is possible if the hostname is > 32
characters that we would just overrun the
client_name data structure.  Truncate
the hostname string to 31 characters (to allow for NULL)

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
---

diff --git a/lib/ptm_lib.c b/lib/ptm_lib.c
index 0666797fad..a93d7b8476 100644
--- a/lib/ptm_lib.c
+++ b/lib/ptm_lib.c
@@ -458,7 +458,7 @@ ptm_lib_register(char *client_name,
     hdl = calloc(1, sizeof(*hdl));
 
     if (hdl) {
-        strcpy(hdl->client_name, client_name);
+        strncpy(hdl->client_name, client_name, PTMLIB_MAXNAMELEN - 1);
         hdl->cmd_cb = cmd_cb;
         hdl->notify_cb = notify_cb;
         hdl->response_cb = response_cb;