From: Fredi Raspall <fredi@voltanet.io>
Date: Sun, 2 May 2021 15:13:11 +0000 (+0200)
Subject: isisd: clear the N-flag in ext. reachability TLVs
X-Git-Tag: base_8.0^2~1
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=8f6a0d6402abc47cbadcbad75698237fd905e6bb;p=mirror%2Ffrr.git

isisd: clear the N-flag in ext. reachability TLVs

If the n-flag-clear option is set in the configuration of a prefix
segment, clear the flag in the extended ip reachability TLVs.

RFCs 7794 and 8667 are not too strict on the setting / clearing the
N-flag in prefix SIDs. However, if there exists a cmd line option
to clear it, it should be cleared in the TLVs announced, as other
vendors do.

Signed-off-by: Fredi Raspall <fredi@voltanet.io>
---

diff --git a/isisd/isis_sr.c b/isisd/isis_sr.c
index c4024772f5..4ea20cd32a 100644
--- a/isisd/isis_sr.c
+++ b/isisd/isis_sr.c
@@ -438,7 +438,7 @@ void isis_sr_prefix_cfg2subtlv(const struct sr_prefix_cfg *pcfg, bool external,
 	}
 	if (external)
 		SET_FLAG(psid->flags, ISIS_PREFIX_SID_READVERTISED);
-	if (pcfg->node_sid)
+	if (pcfg->node_sid && !pcfg->n_flag_clear)
 		SET_FLAG(psid->flags, ISIS_PREFIX_SID_NODE);
 
 	/* Set SID value. */