From: Donatas Abraitis <donatas@opensourcerouting.org>
Date: Fri, 10 Jun 2022 09:35:00 +0000 (+0300)
Subject: bgpd: last_reset_cause_size can't be larger than 65k bytes
X-Git-Tag: base_8.4~374^2~1
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=8dcad8e9fdfea1695e078564fea17bad4ca59adc;p=matthieu%2Ffrr.git

bgpd: last_reset_cause_size can't be larger than 65k bytes

Reduce the scope, to avoid comparing uint16_t vs. size_t in a loop.

```
vty_out(vty,
	"  Message received that caused BGP to send a NOTIFICATION:\n    ");
	for (i = 1; i <= p->last_reset_cause_size;
	     i++) {
```

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
---

diff --git a/bgpd/bgpd.h b/bgpd/bgpd.h
index bf26bdc5b0..98e59bcc85 100644
--- a/bgpd/bgpd.h
+++ b/bgpd/bgpd.h
@@ -1637,7 +1637,7 @@ struct peer {
 	 * a new value to the last_reset reason
 	 */
 
-	size_t last_reset_cause_size;
+	uint16_t last_reset_cause_size;
 	uint8_t last_reset_cause[BGP_MAX_PACKET_SIZE];
 
 	/* The kind of route-map Flags.*/