From: David Lamparter Date: Sun, 6 Jul 2014 20:33:48 +0000 (+0200) Subject: tests/bgpd: don't hardcode error number (fix f57000c) X-Git-Tag: frr-2.0-rc1~1572^2~7 X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=8b16ed74fa61523c3348d2584b66a56a8ad4e350;p=mirror%2Ffrr.git tests/bgpd: don't hardcode error number (fix f57000c) f57000c ("bgpd: don't send NOTIFY twice for malformed attrs") introduces BGP_ATTR_PARSE_ERROR_NOTIFYPLS as additional error code that implies the caller should sent a NOTIFY and convert it to BGP_ATTR_PARSE_ERROR. Sadly, the latter was hardcoded in bgp_mp_attr_test.c, which now didn't consider the new value to be an error. Make the testcase treat all nonzero values as error without discern. Signed-off-by: David Lamparter --- diff --git a/tests/bgp_mp_attr_test.c b/tests/bgp_mp_attr_test.c index 177c1ad8dc..aa8e485d6e 100644 --- a/tests/bgp_mp_attr_test.c +++ b/tests/bgp_mp_attr_test.c @@ -478,7 +478,7 @@ parse_test (struct peer *peer, struct test_segment *t, int type) printf ("parsed?: %s\n", ret ? "no" : "yes"); - if (ret != t->parses) + if ((ret == 0) != (t->parses == 0)) failed++; if (tty)