From: Donald Sharp <sharpd@nvidia.com>
Date: Mon, 26 Oct 2020 13:19:18 +0000 (-0400)
Subject: zebra: Don't do expensive string manip if not in debug
X-Git-Tag: base_7.6~335^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=82144f532bdb027bafc3ba26bb0191c4cffdf06b;p=matthieu%2Ffrr.git

zebra: Don't do expensive string manip if not in debug

Modify the code to not load up a string that is only used
in debugging unless we are debugging.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
---

diff --git a/zebra/zebra_rib.c b/zebra/zebra_rib.c
index 08daddb164..093e1c4095 100644
--- a/zebra/zebra_rib.c
+++ b/zebra/zebra_rib.c
@@ -3083,16 +3083,15 @@ void rib_delete(afi_t afi, safi_t safi, vrf_id_t vrf_id, int type,
 	/* Lookup route node. */
 	rn = srcdest_rnode_lookup(table, p, src_p);
 	if (!rn) {
-		char src_buf[PREFIX_STRLEN];
-
-		if (src_p && src_p->prefixlen)
-			prefix2str(src_p, src_buf, sizeof(src_buf));
-		else
-			src_buf[0] = '\0';
-
 		if (IS_ZEBRA_DEBUG_RIB) {
+			char src_buf[PREFIX_STRLEN];
 			struct vrf *vrf = vrf_lookup_by_id(vrf_id);
 
+			if (src_p && src_p->prefixlen)
+				prefix2str(src_p, src_buf, sizeof(src_buf));
+			else
+				src_buf[0] = '\0';
+
 			zlog_debug("%s[%d]:%pFX%s%s doesn't exist in rib",
 				   vrf->name, table_id, p,
 				   (src_buf[0] != '\0') ? " from " : "",