From: Quentin Young <qlyoung@cumulusnetworks.com>
Date: Tue, 26 Feb 2019 20:35:29 +0000 (+0000)
Subject: pimd: strncpy -> strlcpy
X-Git-Tag: 7.1_pulled~200^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=81c077d096b60ad4bf25e52628affe02886e6d2d;p=mirror%2Ffrr.git

pimd: strncpy -> strlcpy

strncpy is a byte copy function not a string copy function

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
---

diff --git a/pimd/pim_register.c b/pimd/pim_register.c
index b9908ae22b..4b402de634 100644
--- a/pimd/pim_register.c
+++ b/pimd/pim_register.c
@@ -189,8 +189,8 @@ void pim_register_send(const uint8_t *buf, int buf_size, struct in_addr src,
 
 	if (PIM_DEBUG_PIM_REG) {
 		char rp_str[INET_ADDRSTRLEN];
-		strncpy(rp_str, inet_ntoa(rpg->rpf_addr.u.prefix4),
-			INET_ADDRSTRLEN - 1);
+		strlcpy(rp_str, inet_ntoa(rpg->rpf_addr.u.prefix4),
+			sizeof(rp_str));
 		zlog_debug("%s: Sending %s %sRegister Packet to %s on %s",
 			   __PRETTY_FUNCTION__, up->sg_str,
 			   null_register ? "NULL " : "", rp_str, ifp->name);