From: Philippe Guibert <philippe.guibert@6wind.com>
Date: Wed, 18 Jul 2018 15:58:45 +0000 (+0200)
Subject: zebra: sometimes, it is not possible to assign a NSID to a vrf
X-Git-Tag: frr-5.0.2~13^2~1
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=7df530bc8a3eedfc0eb32e3a4c5c48e99f9053dd;p=matthieu%2Ffrr.git

zebra: sometimes, it is not possible to assign a NSID to a vrf

This test case happens in scenarios with mininet, where external netns
may be impossible for the local instance to be modified. The error is
ignored and the netns parsed is ignored too.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
---

diff --git a/zebra/zebra_netns_notify.c b/zebra/zebra_netns_notify.c
index 30f850597c..7ca7b1e383 100644
--- a/zebra/zebra_netns_notify.c
+++ b/zebra/zebra_netns_notify.c
@@ -80,6 +80,8 @@ static void zebra_ns_notify_create_context_from_entry_name(const char *name)
 	ns_id = zebra_ns_id_get(netnspath);
 	if (zserv_privs.change(ZPRIVS_LOWER))
 		zlog_err("Can't lower privileges");
+	if (ns_id == NS_UNKNOWN)
+		return;
 	ns_id_external = ns_map_nsid_with_external(ns_id, true);
 	/* if VRF with NS ID already present */
 	vrf = vrf_lookup_by_id((vrf_id_t)ns_id_external);