From: David Lamparter <equinox@opensourcerouting.org>
Date: Sat, 7 Mar 2015 07:40:48 +0000 (+0100)
Subject: zebra: don't print uninitialized string (3b02fe8)
X-Git-Tag: frr-2.0-rc1~825
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=7d20b83094f8bb9acecc29bbcc87fe61a1d440d7;p=mirror%2Ffrr.git

zebra: don't print uninitialized string (3b02fe8)

This crept in as part of the MRIB improvements and I missed the compiler
warning between other noise.  Unfortunately, printing an uninitialised
variable can in fact make zebra crash, so this is not trivial.

Fixes: 3b02fe8 ("zebra: add "show ip rpf" to get result of RPF lookup")
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
---

diff --git a/zebra/zebra_vty.c b/zebra/zebra_vty.c
index 60e793d0af..7addb3509e 100644
--- a/zebra/zebra_vty.c
+++ b/zebra/zebra_vty.c
@@ -1916,7 +1916,7 @@ vty_show_ip_route_detail (struct vty *vty, struct route_node *rn, int mcast)
 
   RNODE_FOREACH_RIB (rn, rib)
     {
-      const char *mcast_info;
+      const char *mcast_info = "";
       if (mcast)
         {
           rib_table_info_t *info = rn->table->info;
@@ -1924,8 +1924,6 @@ vty_show_ip_route_detail (struct vty *vty, struct route_node *rn, int mcast)
                        ? " using Multicast RIB"
                        : " using Unicast RIB";
         }
-      else
-	mcast_info = "";
       
       vty_out (vty, "Routing entry for %s/%d%s%s",
               inet_ntoa (rn->p.u.prefix4), rn->p.prefixlen, mcast_info,