From: Donald Sharp <sharpd@nvidia.com>
Date: Wed, 15 Jan 2025 18:03:52 +0000 (-0500)
Subject: zebra: Add some documentation on when zserv_open should be used
X-Git-Tag: docker/10.3.0~41^2~2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=791ec8ebdd9e492fcf6359cd086bbea0bb5efd58;p=matthieu%2Ffrr.git

zebra: Add some documentation on when zserv_open should be used

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
(cherry picked from commit 4b967527376db4f08c50f9c32cc77556700d0eec)
---

diff --git a/zebra/zserv.c b/zebra/zserv.c
index 7ef3582329..6965c285cd 100644
--- a/zebra/zserv.c
+++ b/zebra/zserv.c
@@ -937,6 +937,10 @@ void zserv_close(void)
 /*
  * Open zebra's ZAPI listener socket. This is done early during startup,
  * before zebra is ready to listen and accept client connections.
+ *
+ * This function should only ever be called from the startup pthread
+ * from main.c.  If it is called multiple times it will cause problems
+ * because it causes the zsock global variable to be setup.
  */
 void zserv_open(const char *path)
 {
diff --git a/zebra/zserv.h b/zebra/zserv.h
index ce47ef19fa..1ff7ccd981 100644
--- a/zebra/zserv.h
+++ b/zebra/zserv.h
@@ -262,6 +262,9 @@ extern void zserv_close(void);
  *
  * path
  *    where to place the Unix domain socket
+ *
+ * This function *should* only ever be called from
+ * main() and only every from 1 pthread.
  */
 extern void zserv_open(const char *path);