From: Dmitry Tejblum <tejblum@yandex-team.ru>
Date: Tue, 23 Jun 2009 13:16:32 +0000 (+0400)
Subject: [ospfd] cancel OSPF timer hack in nsm_change_state
X-Git-Tag: frr-2.0-rc1~2269^2~1
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=774eb1524c3a1e0a9567e6aff3315b4686ab3e75;p=matthieu%2Ffrr.git

[ospfd] cancel OSPF timer hack in nsm_change_state

This piece of code causes all Quagga routers on a broadcast link to
send a HELLO packet simultaneously if they see a new neighbor. It also
resets the HELLO timer, so all the quagga routers will continue to
send HELLO packets simultaneously in the future. This is not good
(especially on networks with a lot of Quagga routers connected), and
is explicitly discouraged by the OSPF standard, RFC 2328 (chapter
4.4.Timers).

I suggest to remove the code snippet, it does not provide much benefit
anyway.
---

diff --git a/ospfd/ospf_nsm.c b/ospfd/ospf_nsm.c
index f3ac9eaaeb..15fff349ac 100644
--- a/ospfd/ospf_nsm.c
+++ b/ospfd/ospf_nsm.c
@@ -778,14 +778,6 @@ nsm_change_state (struct ospf_neighbor *nbr, int state)
     break;
   }
 
-  /* Performance hack. Send hello immideately when some neighbor enter
-     Init state.  This whay we decrease neighbor discovery time. Gleb.*/
-  if (state == NSM_Init)
-    {
-      OSPF_ISM_TIMER_OFF (oi->t_hello);
-      OSPF_ISM_TIMER_MSEC_ON (oi->t_hello, ospf_hello_timer, 1);
-    }
-
   /* Preserve old status? */
 }