From: Denis Ovsienko <linux@pilot.org.ua>
Date: Thu, 4 Oct 2007 15:09:19 +0000 (+0000)
Subject: + pidfiles are now always created with 0644 perms instead if LOGFILE_MASK (0600)
X-Git-Tag: frr-2.0-rc1~2457
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=7593fddfa1558d086e3142ad96cf2790007f5d84;p=mirror%2Ffrr.git

+ pidfiles are now always created with 0644 perms instead if LOGFILE_MASK (0600)
---

diff --git a/lib/ChangeLog b/lib/ChangeLog
index 8125451f8b..887c785459 100644
--- a/lib/ChangeLog
+++ b/lib/ChangeLog
@@ -1,3 +1,9 @@
+2007-10-04 Denis Ovsienko
+
+	* pid_output.c: (pid_output) stop using LOGFILE_MASK
+	  (0600 by default), introduce and use PIDFILE_MASK (0644)
+	  instead.
+
 2007-09-18  Paul Jakma <paul.jakma@sun.com>
 
 	* privs.c: definition of ZCAP_NET_ADMIN on Solaris should
diff --git a/lib/pid_output.c b/lib/pid_output.c
index a098c63ca8..5261babc6d 100644
--- a/lib/pid_output.c
+++ b/lib/pid_output.c
@@ -25,6 +25,7 @@
 #include <log.h>
 #include "version.h"
 
+#define PIDFILE_MASK 0644
 #ifndef HAVE_FCNTL
 
 pid_t
@@ -36,7 +37,7 @@ pid_output (const char *path)
 
   pid = getpid();
 
-  oldumask = umask(0777 & ~LOGFILE_MASK);
+  oldumask = umask(0777 & ~PIDFILE_MASK);
   fp = fopen (path, "w");
   if (fp != NULL) 
     {
@@ -67,8 +68,8 @@ pid_output (const char *path)
 
   pid = getpid ();
 
-  oldumask = umask(0777 & ~LOGFILE_MASK);
-  fd = open (path, O_RDWR | O_CREAT, LOGFILE_MASK);
+  oldumask = umask(0777 & ~PIDFILE_MASK);
+  fd = open (path, O_RDWR | O_CREAT, PIDFILE_MASK);
   if (fd < 0)
     {
       zlog_err("Can't create pid lock file %s (%s), exiting",