From: Donald Sharp <sharpd@cumulusnetworks.com>
Date: Mon, 9 Oct 2017 20:08:08 +0000 (-0400)
Subject: ospfd: Fix leak of FD
X-Git-Tag: frr-4.0-dev~219^2~5
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=757fd7116809590313132f981d2fbe7e3f0a5e72;p=matthieu%2Ffrr.git

ospfd: Fix leak of FD

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
---

diff --git a/ospfd/ospf_network.c b/ospfd/ospf_network.c
index d1c1429054..699f2341d5 100644
--- a/ospfd/ospf_network.c
+++ b/ospfd/ospf_network.c
@@ -220,8 +220,10 @@ int ospf_sock_init(struct ospf *ospf)
 	}
 
 	ret = ospf_bind_vrfdevice(ospf, ospf_sock);
-	if (ret < 0)
+	if (ret < 0) {
+		close(ospf_sock);
 		goto out;
+	}
 
 #ifdef IP_HDRINCL
 	/* we will include IP header with packet */
@@ -232,6 +234,7 @@ int ospf_sock_init(struct ospf *ospf)
 
 		zlog_warn("Can't set IP_HDRINCL option for fd %d: %s",
 			  ospf_sock, safe_strerror(save_errno));
+		close(ospf_sock);
 		goto out;
 	}
 #elif defined(IPTOS_PREC_INTERNETCONTROL)