From: Donald Sharp <sharpd@nvidia.com>
Date: Thu, 16 Mar 2023 14:24:25 +0000 (-0400)
Subject: bgpd: Use interface name instead of pointer value
X-Git-Tag: frr-8.4.4~49^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=706ec3d3c19fab5fbc1b7bf343397db6059e9f5e;p=mirror%2Ffrr.git

bgpd: Use interface name instead of pointer value

Log message is borked in a manner that makes it unusable:
bgpd[52]: [VX6SM-8YE5W][EC 33554460] 2000:31:0:53::2: nexthop_set failed, resetting connection - intf 0x561eb9005a30

Let's print out the interface name instead.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
(cherry picked from commit 50e049db76573210e3b9ccfa962e5259452ccbe3)
---

diff --git a/bgpd/bgp_network.c b/bgpd/bgp_network.c
index 9ecc2ae4e4..483f377dbe 100644
--- a/bgpd/bgp_network.c
+++ b/bgpd/bgp_network.c
@@ -790,9 +790,12 @@ int bgp_getsockname(struct peer *peer)
 
 	if (!bgp_zebra_nexthop_set(peer->su_local, peer->su_remote,
 				   &peer->nexthop, peer)) {
-		flog_err(EC_BGP_NH_UPD,
-			 "%s: nexthop_set failed, resetting connection - intf %p",
-			 peer->host, peer->nexthop.ifp);
+		flog_err(
+			EC_BGP_NH_UPD,
+			"%s: nexthop_set failed, resetting connection - intf %s",
+			peer->host,
+			peer->nexthop.ifp ? peer->nexthop.ifp->name
+					  : "(Unknown)");
 		return -1;
 	}
 	return 0;