From: David Lamparter Date: Wed, 26 Aug 2009 22:28:28 +0000 (+0200) Subject: rib: default distance value for new protocols (v2) X-Git-Tag: frr-2.0-rc1~1963 X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=7052f22880f439a6ee691dd9436e1bda932f7b3b;p=matthieu%2Ffrr.git rib: default distance value for new protocols (v2) adding protocols and forgetting to update zebra_rib.c currently causes a beyond end of array access for the default distance value. fix by making 150 the default distance for unknown routing protocols. 150 is higher than all other IGPs but lower than iBGP (200) --- diff --git a/zebra/zebra_rib.c b/zebra/zebra_rib.c index 12f3fa5a5b..8228350f09 100644 --- a/zebra/zebra_rib.c +++ b/zebra/zebra_rib.c @@ -67,6 +67,7 @@ static const struct {ZEBRA_ROUTE_OSPF6, 110}, {ZEBRA_ROUTE_ISIS, 115}, {ZEBRA_ROUTE_BGP, 20 /* IBGP is 200. */} + /* no entry/default: 150 */ }; /* Vector for routing table. */ @@ -1511,7 +1512,10 @@ rib_add_ipv4 (int type, int flags, struct prefix_ipv4 *p, /* Set default distance by route type. */ if (distance == 0) { - distance = route_info[type].distance; + if ((unsigned)type >= sizeof(route_info) / sizeof(route_info[0])) + distance = 150; + else + distance = route_info[type].distance; /* iBGP distance is 200. */ if (type == ZEBRA_ROUTE_BGP && CHECK_FLAG (flags, ZEBRA_FLAG_IBGP))