From: Donald Sharp <sharpd@nvidia.com>
Date: Mon, 30 Sep 2024 18:57:45 +0000 (-0400)
Subject: tests: Clean up some logging in test_bgp_default_originate_2links.py
X-Git-Tag: base_10.2~24^2~2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=6ff85fc7484ebf2749eea9a91ef1bf21232cb466;p=mirror%2Ffrr.git

tests: Clean up some logging in test_bgp_default_originate_2links.py

Test was confusing.  Add some useful data and clean up some debugs

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
---

diff --git a/tests/topotests/bgp_default_originate/test_bgp_default_originate_2links.py b/tests/topotests/bgp_default_originate/test_bgp_default_originate_2links.py
index f4f874f942..bcdd987889 100644
--- a/tests/topotests/bgp_default_originate/test_bgp_default_originate_2links.py
+++ b/tests/topotests/bgp_default_originate/test_bgp_default_originate_2links.py
@@ -266,21 +266,21 @@ def verify_the_uptime(time_stamp_before, time_stamp_after, incremented=None):
     if incremented == True:
         if uptime_before < uptime_after:
             logger.info(
-                "  The Uptime [{}] is incremented than [{}].......PASSED ".format(
+                "  The Uptime before [{}] is less than [{}].......PASSED ".format(
                     time_stamp_before, time_stamp_after
                 )
             )
             return True
         else:
             logger.error(
-                "  The Uptime [{}] is expected to be incremented than [{}].......FAILED ".format(
+                "  The Uptime before [{}] is greater than the uptime after [{}].......FAILED ".format(
                     time_stamp_before, time_stamp_after
                 )
             )
             return False
     else:
         logger.info(
-            "  The Uptime [{}] is not incremented than [{}] ".format(
+            "  The Uptime before [{}] the same as after [{}] ".format(
                 time_stamp_before, time_stamp_after
             )
         )
@@ -1027,7 +1027,7 @@ def test_verify_bgp_default_originate_with_default_static_route_p1(request):
     result = verify_the_uptime(uptime_before_ipv6, uptime_after_ipv6, incremented=False)
     assert result is True, "Testcase {} : Failed Error: {}".format(tc_name, result)
 
-    step("Taking uptime snapshot before  removing   redisctribute static ")
+    step("Taking uptime snapshot before removing redistribute static")
     uptime_before_ipv4 = get_rib_route_uptime(tgen, "ipv4", "r2", ipv4_uptime_dict)
     uptime_before_ipv6 = get_rib_route_uptime(tgen, "ipv6", "r2", ipv6_uptime_dict)
     sleep(1)
@@ -1074,6 +1074,7 @@ def test_verify_bgp_default_originate_with_default_static_route_p1(request):
     )
     assert result is True, "Testcase {} : Failed Error: {}".format(tc_name, result)
 
+    step("Now look that the route is not pointed at link2")
     result = verify_rib_default_route(
         tgen,
         topo,
@@ -1093,7 +1094,7 @@ def test_verify_bgp_default_originate_with_default_static_route_p1(request):
     )
     assert result is not True, "Testcase {} : Failed Error: {}".format(tc_name, result)
 
-    step("Taking uptime snapshot before  removing   redisctribute static ")
+    step("Taking uptime snapshot after removing redistribute static")
     uptime_after_ipv4 = get_rib_route_uptime(tgen, "ipv4", "r2", ipv4_uptime_dict)
     uptime_after_ipv6 = get_rib_route_uptime(tgen, "ipv6", "r2", ipv6_uptime_dict)