From: Vincent JARDIN <vincent.jardin@6wind.com>
Date: Sun, 8 Oct 2017 22:06:08 +0000 (+0200)
Subject: eigrpd: fix clang warning
X-Git-Tag: frr-4.0-dev~233^2~1
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=6c86ed54c2f8774ba379b0c1dc328bd1c5addefb;p=matthieu%2Ffrr.git

eigrpd: fix clang warning

nbr cannot be NULL. Doing such test does confuse clang since
we do not have execution case if nbr == NULL.

Signed-off-by: Vincent Jardin <vincent.jardin@6wind.com>
---

diff --git a/eigrpd/eigrp_packet.c b/eigrpd/eigrp_packet.c
index 29d95f17b2..83ff194729 100644
--- a/eigrpd/eigrp_packet.c
+++ b/eigrpd/eigrp_packet.c
@@ -169,7 +169,7 @@ int eigrp_check_md5_digest(struct stream *s,
 	struct TLV_MD5_Authentication_Type *auth_TLV;
 	struct eigrp_header *eigrph;
 
-	if (nbr && ntohl(nbr->crypt_seqnum) > ntohl(authTLV->key_sequence)) {
+	if (ntohl(nbr->crypt_seqnum) > ntohl(authTLV->key_sequence)) {
 		zlog_warn(
 			"interface %s: eigrp_check_md5 bad sequence %d (expect %d)",
 			IF_NAME(nbr->ei), ntohl(authTLV->key_sequence),