From: Donald Sharp <sharpd@cumulusnetworks.com>
Date: Wed, 20 May 2015 00:24:41 +0000 (-0700)
Subject: Add a null check to ensure that another thread
X-Git-Tag: frr-2.0-rc1~1562
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=64e34726a184d42e4118efecbc283267a979dd6a;p=mirror%2Ffrr.git

Add a null check to ensure that another thread
does not access the address in the deletion path
of the interface.

Signed-off-by: Ayan Banerjee <ayan@cumulusnetworks.com>
Reviewed-by: Dinesh G Dutt <ddutt@cumulusnetworks.com>
---

diff --git a/ospfd/ospf_dump.c b/ospfd/ospf_dump.c
index ebcc717ff3..de62e0b7fa 100644
--- a/ospfd/ospf_dump.c
+++ b/ospfd/ospf_dump.c
@@ -204,7 +204,7 @@ ospf_if_name_string (struct ospf_interface *oi)
   static char buf[OSPF_IF_STRING_MAXLEN] = "";
   u_int32_t ifaddr;
 
-  if (!oi)
+  if (!oi || !oi->address)
     return "inactive";
 
   if (oi->type == OSPF_IFTYPE_VIRTUALLINK)