From: Stefan Hanreich <s.hanreich@proxmox.com>
Date: Mon, 10 Mar 2025 08:50:59 +0000 (+0100)
Subject: ipam: netbox: no conditional assignments for descriptions
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=5ff8aeb080ae99230fc6d2825722f49fd0fca3c0;p=matthieu%2Fpve-network.git

ipam: netbox: no conditional assignments for descriptions

While it should make practically no difference, it opens up potential
errors in the future, so just remove the conditional assignments and
explicitly define the variable as undef, so the intention is more
clear.

Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
Tested-by: Hannes Duerr <h.duerr@proxmox.com>
Link: https://lore.proxmox.com/20250310085103.30549-4-s.hanreich@proxmox.com
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---

diff --git a/src/PVE/Network/SDN/Ipams/NetboxPlugin.pm b/src/PVE/Network/SDN/Ipams/NetboxPlugin.pm
index 6595cbc..b51842c 100644
--- a/src/PVE/Network/SDN/Ipams/NetboxPlugin.pm
+++ b/src/PVE/Network/SDN/Ipams/NetboxPlugin.pm
@@ -169,7 +169,8 @@ sub add_next_freeip {
 	die "could not find id for prefix $cidr";
     }
 
-    my $description = "mac:$mac" if $mac;
+    my $description = undef;
+    $description = "mac:$mac" if $mac;
 
     eval {
 	my $result = netbox_api_request($plugin_config, "POST", "/ipam/prefixes/$internalid/available-ips/", {
@@ -197,7 +198,8 @@ sub add_range_next_freeip {
 	die "could not find id for ip range $range->{'start-address'}:$range->{'end-address'}";
     }
 
-    my $description = "mac:$data->{mac}" if $data->{mac};
+    my $description = undef;
+    $description = "mac:$data->{mac}" if $data->{mac};
 
     eval {
 	my $result = netbox_api_request($plugin_config, "POST", "/ipam/ip-ranges/$internalid/available-ips/", {