From: anlan_cs <anlan_cs@126.com>
Date: Sun, 6 Oct 2024 13:06:15 +0000 (+0800)
Subject: isisd: fix wrong check for MT commands
X-Git-Tag: docker/10.1.2~43^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=5bc541c4306e684f866b62d4d1ac22b111347dfa;p=matthieu%2Ffrr.git

isisd: fix wrong check for MT commands

```
anlan# show run
!
interface eth0
 ip router isis A
exit
!
router isis A
 metric-style narrow <- NOT wide
exit
!
end
anlan (config)# int eth0
anlan (config-if)# no isis topology ipv6-unicast
% Configuration failed.

Error type: validation
Error description: Multi topology IS-IS can only be used with wide metrics
```

The MT commands are mainly controlled by the binded area, not by interface.
Currently if there is any MT configuration in the area, `metric-style` must
be with the `wide` mode, this requirement is sufficient.  So, the
unnecessary/wrong check for MT in the interface should be removed.

Signed-off-by: anlan_cs <anlan_cs@126.com>
(cherry picked from commit 424cec61c0860c74436954a1f8ba6ee7fe8e04a5)
---

diff --git a/isisd/isis_nb_config.c b/isisd/isis_nb_config.c
index 763b8b73d2..e5b9552bd3 100644
--- a/isisd/isis_nb_config.c
+++ b/isisd/isis_nb_config.c
@@ -4300,14 +4300,6 @@ static int lib_interface_isis_multi_topology_common(
 
 	switch (event) {
 	case NB_EV_VALIDATE:
-		circuit = nb_running_get_entry(dnode, NULL, false);
-		if (circuit && circuit->area && circuit->area->oldmetric) {
-			snprintf(
-				errmsg, errmsg_len,
-				"Multi topology IS-IS can only be used with wide metrics");
-			return NB_ERR_VALIDATION;
-		}
-		break;
 	case NB_EV_PREPARE:
 	case NB_EV_ABORT:
 		break;