From: David Lamparter Date: Mon, 20 May 2019 21:41:16 +0000 (+0200) Subject: bgpd: use DLIST for adv_fifo X-Git-Tag: base_7.2~319^2~6 X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=5ac8ecbabd9638f726fdff5d49b43e675a47e434;p=matthieu%2Ffrr.git bgpd: use DLIST for adv_fifo I mistakenly assumed that something called "FIFO" would primarily be used by removing items from the front. This isn't the case for the adv_fifo... so use a DLIST there to make sure deletions from the middle of the queue are fast. Signed-off-by: David Lamparter --- diff --git a/bgpd/bgp_advertise.h b/bgpd/bgp_advertise.h index 7d2fdf1f0b..1b55b6e64b 100644 --- a/bgpd/bgp_advertise.h +++ b/bgpd/bgp_advertise.h @@ -23,7 +23,7 @@ #include "lib/typesafe.h" -PREDECL_LIST(bgp_adv_fifo) +PREDECL_DLIST(bgp_adv_fifo) struct update_subgroup; @@ -60,7 +60,7 @@ struct bgp_advertise { struct bgp_path_info *pathi; }; -DECLARE_LIST(bgp_adv_fifo, struct bgp_advertise, fifo) +DECLARE_DLIST(bgp_adv_fifo, struct bgp_advertise, fifo) /* BGP adjacency out. */ struct bgp_adj_out {