From: Paul Jakma <paul.jakma@sun.com>
Date: Mon, 8 May 2006 14:25:09 +0000 (+0000)
Subject: [bgpd] CID#62 fix double-free, use-after-free in community_str2com
X-Git-Tag: frr-2.0-rc1~2725
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=542bcb724c410283d7a3f317c8fe5e8a0b58f196;p=mirror%2Ffrr.git

[bgpd] CID#62 fix double-free, use-after-free in community_str2com

2006-05-08 Paul Jakma <paul.jakma@sun.com>

	* bgp_community.c: (community_str2com) Coverity CID#62, fix
	  double-free, use-after-free.
---

diff --git a/bgpd/ChangeLog b/bgpd/ChangeLog
index 5599801e68..16a56fc2b9 100644
--- a/bgpd/ChangeLog
+++ b/bgpd/ChangeLog
@@ -1,3 +1,8 @@
+2006-05-08 Paul Jakma <paul.jakma@sun.com>
+
+	* bgp_community.c: (community_str2com) Coverity CID#62, fix
+	  double-free, use-after-free.
+
 2006-05-04 Paul Jakma <paul.jakma@sun.com>
 
 	* (general) VPNv4 fixes. Certain VPNv4 code was not enabled.
diff --git a/bgpd/bgp_community.c b/bgpd/bgp_community.c
index b419a203b7..07b8cf81f8 100644
--- a/bgpd/bgp_community.c
+++ b/bgpd/bgp_community.c
@@ -596,7 +596,7 @@ community_str2com (const char *str)
 	default:
 	  if (com)
 	    community_free (com);
-	  break;
+	  return NULL;
 	}
     } while (str);