From: Quentin Young <qlyoung@cumulusnetworks.com>
Date: Thu, 19 Jan 2017 17:07:39 +0000 (+0000)
Subject: lib: guard strict cli completions
X-Git-Tag: frr-3.0-branchpoint~77^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=5320569435c057a4e209700bdad71256432536fc;p=matthieu%2Ffrr.git

lib: guard strict cli completions

Completions are checked for token and docstring equality before
deduplicating. Put an ifdef guard around checking docstrings because
many of them are inconsistent and may confuse users in a release build.

It is a good idea to enable VTYSH_DEBUG when adding new CLI in the
future to help check docstrings.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
---

diff --git a/lib/command.c b/lib/command.c
index 6294e994e7..b5dae5f28e 100644
--- a/lib/command.c
+++ b/lib/command.c
@@ -541,8 +541,12 @@ completions_to_vec (struct list *completions)
     for (i = 0; i < vector_active (comps) && !exists; i++)
     {
       struct cmd_token *curr = vector_slot (comps, i);
+#ifdef VTYSH_DEBUG
       exists = !strcmp (curr->text, token->text) &&
                !strcmp (curr->desc, token->desc);
+#else
+      exists = !strcmp (curr->text, token->text);
+#endif /* VTYSH_DEBUG */
     }
 
     if (!exists)