From: Donald Sharp <sharpd@nvidia.com>
Date: Tue, 7 Sep 2021 20:51:27 +0000 (-0400)
Subject: tests: Remove unneeded calls to addKernelRoutes
X-Git-Tag: base_8.1~95^2~1
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=51eb2eef3c0827e13aa2acf9e5a157907e4449a7;p=matthieu%2Ffrr.git

tests: Remove unneeded calls to addKernelRoutes

There is no need to add calls to addKernelRoutes for
groups.  They do not need to be routed via the
normal kernel methodology.

Tests run successfully with this change.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
---

diff --git a/tests/topotests/multicast_pim_bsm_topo1/test_mcast_pim_bsmp_01.py b/tests/topotests/multicast_pim_bsm_topo1/test_mcast_pim_bsmp_01.py
index f1b13cbd02..a94dcb505a 100644
--- a/tests/topotests/multicast_pim_bsm_topo1/test_mcast_pim_bsmp_01.py
+++ b/tests/topotests/multicast_pim_bsm_topo1/test_mcast_pim_bsmp_01.py
@@ -306,12 +306,6 @@ def pre_config_to_bsm(tgen, topo, tc_name, bsr, sender, receiver, fhr, rp, lhr,
         result = create_static_routes(tgen, input_dict)
         assert result is True, "Testcase {} :Failed \n Error {}".format(tc_name, result)
 
-    # Add kernal route for source
-    group = topo["routers"][bsr]["bsm"]["bsr_packets"][packet]["pkt_dst"]
-    bsr_interface = topo["routers"][bsr]["links"][fhr]["interface"]
-    result = addKernelRoute(tgen, bsr, bsr_interface, group)
-    assert result is True, "Testcase {} :Failed \n Error {}".format(tc_name, result)
-
     # RP Mapping
     rp_mapping = topo["routers"][bsr]["bsm"]["bsr_packets"][packet]["rp_mapping"]
 
@@ -325,16 +319,6 @@ def pre_config_to_bsm(tgen, topo, tc_name, bsr, sender, receiver, fhr, rp, lhr,
         if int(mask) == 32:
             group = group.split("/")[0]
 
-        # Add kernal routes for sender
-        s_interface = topo["routers"][sender]["links"][fhr]["interface"]
-        result = addKernelRoute(tgen, sender, s_interface, group)
-        assert result is True, "Testcase {} :Failed \n Error {}".format(tc_name, result)
-
-        # Add kernal routes for receiver
-        r_interface = topo["routers"][receiver]["links"][lhr]["interface"]
-        result = addKernelRoute(tgen, receiver, r_interface, group)
-        assert result is True, "Testcase {} :Failed \n Error {}".format(tc_name, result)
-
         # Add static routes for RPs in FHR and LHR
         next_hop_fhr = topo["routers"][rp]["links"][fhr]["ipv4"].split("/")[0]
         next_hop_lhr = topo["routers"][rp]["links"][lhr]["ipv4"].split("/")[0]