From: Igor Ryzhov <iryzhov@nfware.com>
Date: Wed, 28 Jul 2021 22:17:50 +0000 (+0300)
Subject: bgpd: fix incorrect usage of slist in dampening
X-Git-Tag: base_8.1~266^2~5
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=5054cfcbbc8c776a91e9390d36cff891d0890b4f;p=mirror%2Ffrr.git

bgpd: fix incorrect usage of slist in dampening

Current code is a complete misuse of SLIST structure. Instead of just
adding a SLIST_ENTRY to struct bgp_damp_info, it allocates a separate
structure to be a node in the list.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
---

diff --git a/bgpd/bgp_damp.c b/bgpd/bgp_damp.c
index 7f1abb73c0..bf61d73588 100644
--- a/bgpd/bgp_damp.c
+++ b/bgpd/bgp_damp.c
@@ -40,72 +40,33 @@
 static void bgp_reuselist_add(struct reuselist *list,
 			      struct bgp_damp_info *info)
 {
-	struct reuselist_node *new_node;
-
 	assert(info);
-	new_node = XCALLOC(MTYPE_BGP_DAMP_REUSELIST, sizeof(*new_node));
-	new_node->info = info;
-	SLIST_INSERT_HEAD(list, new_node, entry);
+	SLIST_INSERT_HEAD(list, info, entry);
 }
 
 static void bgp_reuselist_del(struct reuselist *list,
-			      struct reuselist_node **node)
+			      struct bgp_damp_info *info)
 {
-	if ((*node) == NULL)
-		return;
-	assert(list && node && *node);
-	SLIST_REMOVE(list, (*node), reuselist_node, entry);
-	XFREE(MTYPE_BGP_DAMP_REUSELIST, (*node));
-	*node = NULL;
+	assert(info);
+	SLIST_REMOVE(list, info, bgp_damp_info, entry);
 }
 
 static void bgp_reuselist_switch(struct reuselist *source,
-				 struct reuselist_node *node,
+				 struct bgp_damp_info *info,
 				 struct reuselist *target)
 {
-	assert(source && target && node);
-	SLIST_REMOVE(source, node, reuselist_node, entry);
-	SLIST_INSERT_HEAD(target, node, entry);
-}
-
-static void bgp_reuselist_free(struct reuselist *list)
-{
-	struct reuselist_node *rn;
-
-	assert(list);
-	while ((rn = SLIST_FIRST(list)) != NULL)
-		bgp_reuselist_del(list, &rn);
-}
-
-static struct reuselist_node *bgp_reuselist_find(struct reuselist *list,
-						 struct bgp_damp_info *info)
-{
-	struct reuselist_node *rn;
-
-	assert(list && info);
-	SLIST_FOREACH (rn, list, entry) {
-		if (rn->info == info)
-			return rn;
-	}
-	return NULL;
+	assert(source && target && info);
+	SLIST_REMOVE(source, info, bgp_damp_info, entry);
+	SLIST_INSERT_HEAD(target, info, entry);
 }
 
 static void bgp_damp_info_unclaim(struct bgp_damp_info *bdi)
 {
-	struct reuselist_node *node;
-
 	assert(bdi && bdi->config);
-	if (bdi->index == BGP_DAMP_NO_REUSE_LIST_INDEX) {
-		node = bgp_reuselist_find(&bdi->config->no_reuse_list, bdi);
-		if (node)
-			bgp_reuselist_del(&bdi->config->no_reuse_list, &node);
-	} else {
-		node = bgp_reuselist_find(&bdi->config->reuse_list[bdi->index],
-					  bdi);
-		if (node)
-			bgp_reuselist_del(&bdi->config->reuse_list[bdi->index],
-					  &node);
-	}
+	if (bdi->index == BGP_DAMP_NO_REUSE_LIST_INDEX)
+		bgp_reuselist_del(&bdi->config->no_reuse_list, bdi);
+	else
+		bgp_reuselist_del(&bdi->config->reuse_list[bdi->index], bdi);
 	bdi->config = NULL;
 }
 
@@ -187,19 +148,9 @@ static void bgp_no_reuse_list_add(struct bgp_damp_info *bdi,
 	bgp_reuselist_add(&bdc->no_reuse_list, bdi);
 }
 
-static void bgp_no_reuse_list_delete(struct bgp_damp_info *bdi,
-				     struct bgp_damp_config *bdc)
+static void bgp_no_reuse_list_delete(struct bgp_damp_info *bdi)
 {
-	struct reuselist_node *rn;
-
-	assert(bdc && bdi);
-	if (bdi->config == NULL) {
-		bgp_damp_info_unclaim(bdi);
-		return;
-	}
-	bdi->config = NULL;
-	rn = bgp_reuselist_find(&bdc->no_reuse_list, bdi);
-	bgp_reuselist_del(&bdc->no_reuse_list, &rn);
+	bgp_damp_info_unclaim(bdi);
 }
 
 /* Return decayed penalty value.  */
@@ -225,7 +176,6 @@ static int bgp_reuse_timer(struct thread *t)
 	struct bgp_damp_config *bdc = THREAD_ARG(t);
 	struct bgp_damp_info *bdi;
 	struct reuselist plist;
-	struct reuselist_node *node;
 	struct bgp *bgp;
 	time_t t_now, t_diff;
 
@@ -246,8 +196,7 @@ static int bgp_reuse_timer(struct thread *t)
 	assert(bdc->reuse_offset < bdc->reuse_list_size);
 
 	/* 3. if ( the saved list head pointer is non-empty ) */
-	while ((node = SLIST_FIRST(&plist)) != NULL) {
-		bdi = node->info;
+	while ((bdi = SLIST_FIRST(&plist)) != NULL) {
 		bgp = bdi->path->peer->bgp;
 
 		/* Set t-diff = t-now - t-updated.  */
@@ -278,20 +227,19 @@ static int bgp_reuse_timer(struct thread *t)
 			}
 
 			if (bdi->penalty <= bdc->reuse_limit / 2.0) {
+				bgp_reuselist_del(&plist, bdi);
 				bgp_damp_info_free(bdi, bdc, 1, bdi->afi,
 						   bdi->safi);
-				bgp_reuselist_del(&plist, &node);
 			} else {
-				node->info->index =
-					BGP_DAMP_NO_REUSE_LIST_INDEX;
-				bgp_reuselist_switch(&plist, node,
+				bdi->index = BGP_DAMP_NO_REUSE_LIST_INDEX;
+				bgp_reuselist_switch(&plist, bdi,
 						     &bdc->no_reuse_list);
 			}
 		} else {
 			/* Re-insert into another list (See RFC2439 Section
 			 * 4.8.6).  */
 			bdi->index = bgp_reuse_index(bdi->penalty, bdc);
-			bgp_reuselist_switch(&plist, node,
+			bgp_reuselist_switch(&plist, bdi,
 					     &bdc->reuse_list[bdi->index]);
 		}
 	}
@@ -387,7 +335,7 @@ int bgp_damp_withdraw(struct bgp_path_info *path, struct bgp_dest *dest,
 	if (bdi->penalty >= bdc->suppress_value) {
 		bgp_path_info_set_flag(dest, path, BGP_PATH_DAMPED);
 		bdi->suppress_time = t_now;
-		bgp_no_reuse_list_delete(bdi, bdc);
+		bgp_no_reuse_list_delete(bdi);
 		bgp_reuse_list_add(bdi, bdc);
 	}
 	return BGP_DAMP_USED;
@@ -548,15 +496,13 @@ void bgp_damp_info_clean(struct bgp *bgp, struct bgp_damp_config *bdc,
 			 afi_t afi, safi_t safi)
 {
 	struct bgp_damp_info *bdi;
-	struct reuselist_node *rn;
 	struct reuselist *list;
 	unsigned int i;
 
 	bdc->reuse_offset = 0;
 	for (i = 0; i < bdc->reuse_list_size; ++i) {
 		list = &bdc->reuse_list[i];
-		while ((rn = SLIST_FIRST(list)) != NULL) {
-			bdi = rn->info;
+		while ((bdi = SLIST_FIRST(list)) != NULL) {
 			if (bdi->lastrecord == BGP_RECORD_UPDATE) {
 				bgp_aggregate_increment(bgp, &bdi->dest->p,
 							bdi->path, bdi->afi,
@@ -564,14 +510,13 @@ void bgp_damp_info_clean(struct bgp *bgp, struct bgp_damp_config *bdc,
 				bgp_process(bgp, bdi->dest, bdi->afi,
 					    bdi->safi);
 			}
-			bgp_reuselist_del(list, &rn);
+			bgp_reuselist_del(list, bdi);
 			bgp_damp_info_free(bdi, bdc, 1, afi, safi);
 		}
 	}
 
-	while ((rn = SLIST_FIRST(&bdc->no_reuse_list)) != NULL) {
-		bdi = rn->info;
-		bgp_reuselist_del(&bdc->no_reuse_list, &rn);
+	while ((bdi = SLIST_FIRST(&bdc->no_reuse_list)) != NULL) {
+		bgp_reuselist_del(&bdc->no_reuse_list, bdi);
 		bgp_damp_info_free(bdi, bdc, 1, afi, safi);
 	}
 
@@ -583,10 +528,6 @@ void bgp_damp_info_clean(struct bgp *bgp, struct bgp_damp_config *bdc,
 	XFREE(MTYPE_BGP_DAMP_ARRAY, bdc->reuse_index);
 	bdc->reuse_index_size = 0;
 
-	/* Free reuse list array. */
-	for (i = 0; i < bdc->reuse_list_size; ++i)
-		bgp_reuselist_free(&bdc->reuse_list[i]);
-
 	XFREE(MTYPE_BGP_DAMP_ARRAY, bdc->reuse_list);
 	bdc->reuse_list_size = 0;
 
diff --git a/bgpd/bgp_damp.h b/bgpd/bgp_damp.h
index 8367f291c7..2e41d2fbda 100644
--- a/bgpd/bgp_damp.h
+++ b/bgpd/bgp_damp.h
@@ -61,14 +61,11 @@ struct bgp_damp_info {
 
 	afi_t afi;
 	safi_t safi;
-};
 
-struct reuselist_node {
-	SLIST_ENTRY(reuselist_node) entry;
-	struct bgp_damp_info *info;
+	SLIST_ENTRY(bgp_damp_info) entry;
 };
 
-SLIST_HEAD(reuselist, reuselist_node);
+SLIST_HEAD(reuselist, bgp_damp_info);
 
 /* Specified parameter set configuration. */
 struct bgp_damp_config {