From: Donald Sharp <sharpd@nvidia.com>
Date: Fri, 11 Sep 2020 12:27:28 +0000 (-0400)
Subject: pimd: Warn when we try to build MAXVIFS > 256
X-Git-Tag: base_7.6~567^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=4fdd2942c57a7ce8366533e50bded5a1a0ff2110;p=matthieu%2Ffrr.git

pimd: Warn when we try to build MAXVIFS > 256

We use the pim mroute socket for kernel notifications of events.
Currently this is limited to 8 bits of data.  There are patches
coming down the pike in kernel land to allow this to expand.
Rather than fix this and all the other places we assume MAXVIFS < 256
in the pim code right now.  Leave a land mine for the developer
doing this work to point them in the right direction.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
---

diff --git a/pimd/pimd.c b/pimd/pimd.c
index 6c354a3cc8..811dc96b56 100644
--- a/pimd/pimd.c
+++ b/pimd/pimd.c
@@ -44,6 +44,10 @@
 #include "pim_zebra.h"
 #include "pim_mlag.h"
 
+#if MAXVIFS > 256
+CPP_NOTICE("Work needs to be done to make this work properly via the pim mroute socket\n");
+#endif /* MAXVIFS > 256 */
+
 const char *const PIM_ALL_SYSTEMS = MCAST_ALL_SYSTEMS;
 const char *const PIM_ALL_ROUTERS = MCAST_ALL_ROUTERS;
 const char *const PIM_ALL_PIM_ROUTERS = MCAST_ALL_PIM_ROUTERS;