From: Lou Berger Date: Tue, 27 Mar 2018 12:08:15 +0000 (-0400) Subject: developer: workflow.rst - add text on how to respond to reviews/comments X-Git-Tag: frr-5.0-dev~92^2~1 X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=493e3eed5d4a092a8d735335a8a1c24abd5f57c9;p=matthieu%2Ffrr.git developer: workflow.rst - add text on how to respond to reviews/comments add note that author's shouldn't remove a comment or review. also add a note that automatically generated comments can be deleted by authors and others when such comments are not the most results from that automated comment source. Signed-off-by: Lou Berger --- diff --git a/doc/developer/workflow.rst b/doc/developer/workflow.rst index ff66007f8d..ac74665e8b 100644 --- a/doc/developer/workflow.rst +++ b/doc/developer/workflow.rst @@ -256,7 +256,15 @@ After submitting your changes - Wait for reviewers. Someone will review your code or be assigned to review your code. - - Respond to any comments or concerns the reviewer has. + - Respond to any comments or concerns the reviewer has. Use e-mail or + add a comment via github to respond or to let the reviewer know how + their comment or concern is addressed. + - An author must never delete or manually dismiss someone else's comments + or review. (A review may be overridden by agreement in the weekly + technical meeting.) + - Automatically generated comments, e.g., those generated by CI systems, + may be deleted by authors and others when such comments are not the most + results from that automated comment source. - After all comments and concerns are addressed, expect your patch to be merged.