From: Donald Sharp <sharpd@cumulusnetworks.com>
Date: Tue, 20 Mar 2018 23:14:18 +0000 (-0400)
Subject: zebra: close fd when not needed
X-Git-Tag: frr-5.0-dev~132^2~3
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=4307629f18a33af99ccc8241d50344f9eeeca2e0;p=matthieu%2Ffrr.git

zebra: close fd when not needed

Upon decision that the vrf is not going to be supported
by namespaces close the fd.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
---

diff --git a/zebra/zebra_netns_id.c b/zebra/zebra_netns_id.c
index d278ebe913..57f311aac5 100644
--- a/zebra/zebra_netns_id.c
+++ b/zebra/zebra_netns_id.c
@@ -349,8 +349,10 @@ ns_id_t zebra_ns_id_get_default(void)
 
 	if (fd == -1)
 		return NS_DEFAULT_INTERNAL;
-	if (!vrf_is_backend_netns())
+	if (!vrf_is_backend_netns()) {
+		close(fd);
 		return NS_DEFAULT_INTERNAL;
+	}
 	close(fd);
 	return zebra_ns_id_get((char *)NS_DEFAULT_NAME);
 #else  /* HAVE_NETNS */