From: David Lamparter <equinox@diac24.net>
Date: Mon, 20 Apr 2020 21:17:17 +0000 (+0200)
Subject: lib/zlog: fix coverity warning
X-Git-Tag: base_7.4~57^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=41051697a904d772f45c1479fb80b933aecaa864;p=matthieu%2Ffrr.git

lib/zlog: fix coverity warning

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
---

diff --git a/lib/zlog.c b/lib/zlog.c
index 4cab236994..45726755f8 100644
--- a/lib/zlog.c
+++ b/lib/zlog.c
@@ -238,13 +238,12 @@ void zlog_tls_buffer_init(void)
 
 	mmfd = openat(zlog_tmpdirfd, mmpath,
 		      O_RDWR | O_CREAT | O_EXCL | O_CLOEXEC, 0600);
-	fchown(mmfd, zlog_uid, zlog_gid);
-
 	if (mmfd < 0) {
 		zlog_err("failed to open thread log buffer \"%s\": %s",
 			 mmpath, strerror(errno));
 		goto out_anon;
 	}
+	fchown(mmfd, zlog_uid, zlog_gid);
 
 #ifdef HAVE_POSIX_FALLOCATE
 	if (posix_fallocate(mmfd, 0, TLS_LOG_BUF_SIZE) < 0) {