From: Donald Sharp <sharpd@cumulusnetworks.com>
Date: Wed, 13 Feb 2019 17:49:59 +0000 (-0500)
Subject: zebra: Deletion of a lsp is not a failure event
X-Git-Tag: 7.1_pulled~247^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=3fd385c6852e13e1acc7e09a7a46073b312f8c54;p=matthieu%2Ffrr.git

zebra: Deletion of a lsp is not a failure event

FRR is reporting that a lsp deletion event as a failure
in the log messsages.  This will lead to confusion and
lots of fun debugging.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
---

diff --git a/zebra/zebra_mpls.c b/zebra/zebra_mpls.c
index 0aac7d7b12..78c07f9aaf 100644
--- a/zebra/zebra_mpls.c
+++ b/zebra/zebra_mpls.c
@@ -1800,9 +1800,10 @@ void zebra_mpls_lsp_dplane_result(struct zebra_dplane_ctx *ctx)
 		break;
 
 	case DPLANE_OP_LSP_DELETE:
-		flog_warn(EC_ZEBRA_LSP_DELETE_FAILURE,
-			  "LSP Deletion Failure: in-label %u",
-			  dplane_ctx_get_in_label(ctx));
+		if (status != ZEBRA_DPLANE_REQUEST_SUCCESS)
+			flog_warn(EC_ZEBRA_LSP_DELETE_FAILURE,
+				  "LSP Deletion Failure: in-label %u",
+				  dplane_ctx_get_in_label(ctx));
 		break;
 
 	default: