From: Anuradha Karuppiah <anuradhak@nvidia.com>
Date: Fri, 19 Feb 2021 01:49:20 +0000 (-0800)
Subject: zebra: fix problem with bypass getting set accidentally on all ESs
X-Git-Tag: base_8.0~342^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=3f589fa8ecd0eafadef6938637aa8f442702ae91;p=matthieu%2Ffrr.git

zebra: fix problem with bypass getting set accidentally on all ESs

This was caused because of uninitialized netlint attrs in the bond-member
netlink parse API.

PS: It was caught by the upstream topotests on ARM8 (passed everywhere
else).

Signed-off-by: Anuradha Karuppiah <anuradhak@nvidia.com>
---

diff --git a/zebra/if_netlink.c b/zebra/if_netlink.c
index 61a1807fc9..98bde4b3c0 100644
--- a/zebra/if_netlink.c
+++ b/zebra/if_netlink.c
@@ -724,6 +724,7 @@ static uint8_t netlink_parse_lacp_bypass(struct rtattr **linkinfo)
 	uint8_t bypass = 0;
 	struct rtattr *mbrinfo[IFLA_BOND_SLAVE_MAX + 1];
 
+	memset(mbrinfo, 0, sizeof(mbrinfo));
 	parse_rtattr_nested(mbrinfo, IFLA_BOND_SLAVE_MAX,
 			    linkinfo[IFLA_INFO_SLAVE_DATA]);
 	if (mbrinfo[IFLA_BOND_SLAVE_AD_RX_BYPASS])