From: Donald Sharp <sharpd@nvidia.com>
Date: Sun, 12 Mar 2023 00:37:21 +0000 (-0500)
Subject: pimd: IN_MULTICAST needs host order
X-Git-Tag: docker/8.5.1~47^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=39a0e558ed3761a260327a209c8b2c362ca4348a;p=matthieu%2Ffrr.git

pimd: IN_MULTICAST needs host order

New correct behavior:

eva# conf
eva(config)# ip pim rp 192.168.1.224 224.0.0.0/24
No Path to RP address specified: 192.168.1.224
eva(config)# ip pim rp 224.1.2.3 224.0.0.0/24
% Bad RP address specified: 224.1.2.3
eva(config)#

Fixes: #12970
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
(cherry picked from commit 8083e713562a44744c4c2f4a0aa5cc6e2b2170ff)
---

diff --git a/pimd/pim_util.c b/pimd/pim_util.c
index 273c332c95..1528d22867 100644
--- a/pimd/pim_util.c
+++ b/pimd/pim_util.c
@@ -172,7 +172,7 @@ int pim_get_all_mcast_group(struct prefix *prefix)
 bool pim_addr_is_multicast(pim_addr addr)
 {
 #if PIM_IPV == 4
-	if (IN_MULTICAST(addr.s_addr))
+	if (IN_MULTICAST(ntohl(addr.s_addr)))
 		return true;
 #else
 	if (IN6_IS_ADDR_MULTICAST(&addr))