From: Quentin Young <qlyoung@cumulusnetworks.com>
Date: Fri, 8 Nov 2019 19:32:11 +0000 (+0000)
Subject: staticd: exact match on magic interface names
X-Git-Tag: base_7.3~184^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=38aac4a8fc88f7386a993446b7f46252aedb0e05;p=mirror%2Ffrr.git

staticd: exact match on magic interface names

Don't do a substring match on magic interface names - do an exact match.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
---

diff --git a/staticd/static_vty.c b/staticd/static_vty.c
index f926e1d9cd..8cc4ccced1 100644
--- a/staticd/static_vty.c
+++ b/staticd/static_vty.c
@@ -426,9 +426,9 @@ static int static_route_leak(
 
 	/* Null0 static route.  */
 	if (ifname != NULL) {
-		if (strncasecmp(ifname, "Null0", strlen(ifname)) == 0
-		    || strncasecmp(ifname, "reject", strlen(ifname)) == 0
-		    || strncasecmp(ifname, "blackhole", strlen(ifname)) == 0) {
+		if (strcasecmp(ifname, "Null0") == 0
+		    || strcasecmp(ifname, "reject") == 0
+		    || strcasecmp(ifname, "blackhole") == 0) {
 			if (vty)
 				vty_out(vty,
 					"%% Nexthop interface cannot be Null0, reject or blackhole\n");