From: David Lamparter <equinox@opensourcerouting.org>
Date: Wed, 21 Jul 2021 09:23:23 +0000 (+0200)
Subject: build: use `--coverage` for gcov
X-Git-Tag: frr-8.0.1~67^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=2faed357057731b92a9a96294db2ada3c96122ff;p=mirror%2Ffrr.git

build: use `--coverage` for gcov

libtool does not understand `-coverage` with a single dash.  Official
gcc docs also say `--coverage` rather than `-coverage`.  (clang lists
both.)

Also, for correct linking, libtool needs `--coverage` in LDFLAGS as
opposed to `-lgcov` (with the latter you get library ordering/deps
issues)

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
(cherry picked from commit 81aff2127f35da2ec667bc60989cac7df7a8ef48)
---

diff --git a/configure.ac b/configure.ac
index eae63aa84b..9f9518f6d2 100644
--- a/configure.ac
+++ b/configure.ac
@@ -273,11 +273,11 @@ AC_C_FLAG([-std=gnu11], [CC="$ac_cc"], [CC="$CC -std=gnu11"])
 dnl if the user has specified any CFLAGS, override our settings
 if test "$enable_gcov" = "yes"; then
    if test "$orig_cflags" = ""; then
-      AC_C_FLAG([-coverage])
+      AC_C_FLAG([--coverage])
       AC_C_FLAG([-O0])
    fi
 
-   AC_LDFLAGS="${AC_LDFLAGS} -lgcov"
+   AC_LDFLAGS="${AC_LDFLAGS} --coverage"
 fi
 
 if test "$enable_clang_coverage" = "yes"; then