From: Donald Sharp <sharpd@cumulusnetworks.com>
Date: Mon, 20 Aug 2018 13:05:23 +0000 (-0400)
Subject: lib: Convert to errors some issues in buffer.c
X-Git-Tag: frr-7.1-dev~371^2~39
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=29c7044c633511f260928f83798e1ed17877e407;p=mirror%2Ffrr.git

lib: Convert to errors some issues in buffer.c

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
---

diff --git a/lib/buffer.c b/lib/buffer.c
index 1799c6b94f..bed42f047f 100644
--- a/lib/buffer.c
+++ b/lib/buffer.c
@@ -365,8 +365,9 @@ buffer_status_t buffer_flush_window(struct buffer *b, int fd, int width,
 			iov_size =
 				((iov_index > IOV_MAX) ? IOV_MAX : iov_index);
 			if ((nbytes = writev(fd, c_iov, iov_size)) < 0) {
-				zlog_warn("%s: writev to fd %d failed: %s",
-					  __func__, fd, safe_strerror(errno));
+				flog_err(LIB_ERR_SOCKET,
+					 "%s: writev to fd %d failed: %s",
+					 __func__, fd, safe_strerror(errno));
 				break;
 			}
 
@@ -377,8 +378,9 @@ buffer_status_t buffer_flush_window(struct buffer *b, int fd, int width,
 	}
 #else  /* IOV_MAX */
 	if ((nbytes = writev(fd, iov, iov_index)) < 0)
-		zlog_warn("%s: writev to fd %d failed: %s", __func__, fd,
-			  safe_strerror(errno));
+		flog_err(LIB_ERR_SOCKET,
+			 "%s: writev to fd %d failed: %s", __func__, fd,
+			 safe_strerror(errno));
 #endif /* IOV_MAX */
 
 	/* Free printed buffer data. */
@@ -438,7 +440,8 @@ in one shot. */
 		if (ERRNO_IO_RETRY(errno))
 			/* Calling code should try again later. */
 			return BUFFER_PENDING;
-		zlog_warn("%s: write error on fd %d: %s", __func__, fd,
+		flog_err(LIB_ERR_SOCKET,
+			 "%s: write error on fd %d: %s", __func__, fd,
 			  safe_strerror(errno));
 		return BUFFER_ERROR;
 	}
@@ -493,8 +496,9 @@ buffer_status_t buffer_write(struct buffer *b, int fd, const void *p,
 		if (ERRNO_IO_RETRY(errno))
 			nbytes = 0;
 		else {
-			zlog_warn("%s: write error on fd %d: %s", __func__, fd,
-				  safe_strerror(errno));
+			flog_err(LIB_ERR_SOCKET,
+				 "%s: write error on fd %d: %s", __func__, fd,
+				 safe_strerror(errno));
 			return BUFFER_ERROR;
 		}
 	}