From: Donald Sharp <sharpd@nvidia.com>
Date: Sun, 10 Sep 2023 13:35:38 +0000 (-0400)
Subject: bgpd: bgp_distance_unset ensure dest exists
X-Git-Tag: base_9.1~77^2~12
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=271c00074fba9c04a4fe0b47a8c7e9a4cb0f2143;p=mirror%2Ffrr.git

bgpd: bgp_distance_unset ensure dest exists

Coverity doesn't understand our locking scheme
make sure it does a bit better.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
---

diff --git a/bgpd/bgp_route.c b/bgpd/bgp_route.c
index 7d0cc377bd..4d4a2a5c35 100644
--- a/bgpd/bgp_route.c
+++ b/bgpd/bgp_route.c
@@ -15049,7 +15049,8 @@ static int bgp_distance_unset(struct vty *vty, const char *distance_str,
 	bgp_distance_free(bdistance);
 
 	bgp_dest_set_bgp_path_info(dest, NULL);
-	bgp_dest_unlock_node(dest);
+	dest = bgp_dest_unlock_node(dest);
+	assert(dest);
 	bgp_dest_unlock_node(dest);
 
 	return CMD_SUCCESS;