From: Leonard Tracy <letracy@amazon.com>
Date: Tue, 4 Dec 2012 19:02:35 +0000 (-0800)
Subject: ospf: Fix type-4 network mask to 0 per RFC
X-Git-Tag: frr-2.0-rc1~1724^2~11
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=2345a2221aa0a02b96846beab6088815f41e791b;p=matthieu%2Ffrr.git

ospf: Fix type-4 network mask to 0 per RFC

The OSPF RFC (2328) states that the network mask field of a type 4
LSA "is not meaningful and must be zero".  OSPFD has been setting
the mask as /32.  This patch changes OSPFD to set the mask to 0 per
the RFC

Signed-off-by: Scott Feldman <sfeldma@cumulusnetworks.com>
---

diff --git a/ospfd/ospf_lsa.c b/ospfd/ospf_lsa.c
index 66c7e1c0cc..fb55f7ff12 100644
--- a/ospfd/ospf_lsa.c
+++ b/ospfd/ospf_lsa.c
@@ -1340,12 +1340,8 @@ static void
 ospf_summary_asbr_lsa_body_set (struct stream *s, struct prefix *p,
 				u_int32_t metric)
 {
-  struct in_addr mask;
-
-  masklen2ip (p->prefixlen, &mask);
-
   /* Put Network Mask. */
-  stream_put_ipv4 (s, mask.s_addr);
+  stream_put_ipv4 (s, (u_int32_t) 0);
 
   /* Set # TOS. */
   stream_putc (s, (u_char) 0);