From: Donald Sharp <sharpd@cumulusnetworks.com>
Date: Wed, 5 Jun 2019 01:15:43 +0000 (-0400)
Subject: isisd: The RFC states that v6 addresses are limited to 16 in a hello packet
X-Git-Tag: base_7.2~261^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=1f8286c99b54248d02926d666a25a9208c543da1;p=matthieu%2Ffrr.git

isisd: The RFC states that v6 addresses are limited to 16 in a hello packet

The RFC states we can send only up to 16 v6 addresses in a hello packet
and cannot send sub tlv's of that type.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
---

diff --git a/isisd/isis_tlvs.c b/isisd/isis_tlvs.c
index 6b8e74f07b..6edfeb4c97 100644
--- a/isisd/isis_tlvs.c
+++ b/isisd/isis_tlvs.c
@@ -3271,13 +3271,18 @@ void isis_tlvs_add_ipv6_addresses(struct isis_tlvs *tlvs,
 {
 	struct listnode *node;
 	struct prefix_ipv6 *ip_addr;
+	unsigned int addr_count = 0;
 
 	for (ALL_LIST_ELEMENTS_RO(addresses, node, ip_addr)) {
+		if (addr_count >= 15)
+			break;
+
 		struct isis_ipv6_address *a =
 			XCALLOC(MTYPE_ISIS_TLV, sizeof(*a));
 
 		a->addr = ip_addr->prefix;
 		append_item(&tlvs->ipv6_address, (struct isis_item *)a);
+		addr_count++;
 	}
 }