From: Donatas Abraitis <donatas@opensourcerouting.org>
Date: Wed, 30 Aug 2023 09:33:16 +0000 (+0300)
Subject: bgpd: Unset role when receiving UNSET action for dynamic capability
X-Git-Tag: base_9.1~115^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=1f70ceae0a159aa8c76696e643a3c45f099d5989;p=matthieu%2Ffrr.git

bgpd: Unset role when receiving UNSET action for dynamic capability

Capability was unset, but forgot to unset the role.

Fixes: 5ad080d37a26d72b56ecd0b796593bb7fc3aa6ad ("bgpd: Handle Role capability via dynamic capabilities for SET/UNSET properly")

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
---

diff --git a/bgpd/bgp_packet.c b/bgpd/bgp_packet.c
index 01d73e9b07..99ffe9549f 100644
--- a/bgpd/bgp_packet.c
+++ b/bgpd/bgp_packet.c
@@ -2917,6 +2917,7 @@ static int bgp_capability_msg_parse(struct peer *peer, uint8_t *pnt,
 				peer->remote_role = role;
 			} else {
 				UNSET_FLAG(peer->cap, PEER_CAP_ROLE_RCV);
+				peer->remote_role = ROLE_UNDEFINED;
 			}
 			break;
 		default: