From: Renato Westphal <renato@opensourcerouting.org>
Date: Wed, 26 Jul 2017 01:36:00 +0000 (-0300)
Subject: ldpd: silence coverity scan warning
X-Git-Tag: frr-4.0-dev~479^2~1
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=1e4c86735790cb6c2ffde24fc64841de0541b723;p=matthieu%2Ffrr.git

ldpd: silence coverity scan warning

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
---

diff --git a/ldpd/lde.c b/ldpd/lde.c
index 602dc8805e..77643ff48b 100644
--- a/ldpd/lde.c
+++ b/ldpd/lde.c
@@ -1328,7 +1328,6 @@ lde_nbr_addr_update(struct lde_nbr *ln, struct lde_addr *lde_addr, int removed)
 	struct lde_map		*me;
 
 	RB_FOREACH(fec, fec_tree, &ln->recv_map) {
-		fn = (struct fec_node *)fec_find(&ft, fec);
 		switch (fec->type) {
 		case FEC_TYPE_IPV4:
 			if (lde_addr->af != AF_INET)
@@ -1342,6 +1341,11 @@ lde_nbr_addr_update(struct lde_nbr *ln, struct lde_addr *lde_addr, int removed)
 			continue;
 		}
 
+		fn = (struct fec_node *)fec_find(&ft, fec);
+		if (fn == NULL)
+			/* shouldn't happen */
+			continue;
+
 		LIST_FOREACH(fnh, &fn->nexthops, entry) {
 			if (ldp_addrcmp(fnh->af, &fnh->nexthop,
 			    &lde_addr->addr))